search

jboss-openshift / cct_module

CEKit modules shared by OpenShift container images
Apache License 2.0
45 stars 79 forks source link

Blank maven.conf file instead of removing it #391

Closed jmtd closed 3 years ago

jmtd commented 3 years ago

/usr/bin/mvn complains about the missing file.

jmtd commented 3 years ago

I've just completed a build and S2I test run for the OpenJDK images and they passed, resolving the warning about missing files that @jerboaa flagged.

But, I'd like it if someone on the OpenJ9 side could take a look at this too, to be sure they're happy with it, @levivic is that OK?

levivic commented 3 years ago

@mdrafiur please take a look and verify this.

jmtd commented 3 years ago

It seems missing /etc/java/maven.conf is a fatal error! I missed that because it's only removed for JDK11, not 8, and I must have only tested with ubi8/openjdk-8. This revised PR blanks (not removes) the file for both JDK8 and 11. This should fix https://github.com/jboss-container-images/openjdk/issues/174 (tests still running)

jmtd commented 3 years ago

@mdrafiur I've merged this but please take a look and let me know if you think this causes problems for you!