search

jboss-qa / jcontainer-manager

Tool to manage Java application containers
Apache License 2.0
4 stars 9 forks source link

[closes #58] Create ProcessBuilderExecutor and run container through it #67

Closed mswiech closed 8 years ago

mswiech commented 8 years ago

Tests passed. Does not tested on aix.

basovnik commented 8 years ago

I think that class InputStreamConsumerThread is too complicated. I would transform all possible "output objects" to either OutputStream or Writer and use only one method to write. You duplicate some code. Then your class can have only one main constructor and other constructors only prepare proper "output object". What do you think?

mswiech commented 8 years ago

Refactored and tested.