search

jboss / mojarra

Fork of Mojarra
10 stars 41 forks source link

Fix problem introduced in JAVASERVERFACES_SPEC_PUBLIC-1329, also cons… #46

Closed soul2zimate closed 4 years ago

soul2zimate commented 5 years ago

…ider Submitted value "" when EMPTY_STRING_AS_NULL_PARAM_NAME is enabled.

(cherry picked from commit b1111429d0d66352ea8911c7abc210f1fec5684c) (cherry picked from commit f3507c74b6fbb37797f3da235d8c0a88588b2e06)

issue: https://issues.jboss.org/browse/WFLY-12491

upstream issue: https://github.com/eclipse-ee4j/mojarra/issues/4550 PR: https://github.com/eclipse-ee4j/mojarra/pull/4643

soul2zimate commented 4 years ago

Hi @fjuma would you mind to review this for https://issues.redhat.com/browse/JBEAP-17499 at your convenience time ? the details report and analysis is in upstream issue: https://github.com/eclipse-ee4j/mojarra/issues/4550

fjuma commented 4 years ago

@soul2zimate I added another comment on the upstream PR to try to get a review from them. My concern with this PR is that it is changing the expected values for test cases so ideally we should make sure that upstream is ok with this.

spyrkob commented 4 years ago

Merged since upstream was approved and merged