search

jbossas / jboss-as-maven-plugin

Maven plugin to deploy applications to JBoss AS 7 (moved to https://github.com/wildfly/wildfly-maven-plugin)
74 stars 69 forks source link

Add 'deployEnabled' option to allow a deployed war to remain deactivated #68

Closed Zetten closed 10 years ago

Zetten commented 10 years ago

Allow the deployment of disabled WARs by using the 'add' functionality of JBoss AS in place of 'deploy'.

If 'force' is true, the deployed content will have the same state as an existing deployment, if any. That is, if the existing content is already enabled, the 'add' goal will also enable the replacement content. If the existing content is disabled, the 'add' goal will leave the replacement content disabled.

jamezp commented 10 years ago

I think rather than a separate goal an enable parameter might be an easier option. The default would be true, but false would just use the builder.add(). I'd rather not add too many goals to the plugin.

Zetten commented 10 years ago

That makes a lot more sense, actually. I remember considering it but then when I hacked it out quickly this morning I must have forgotten and headed the other way. I'll add the new parameter and amend.

jamezp commented 10 years ago

Look good!

We require that all contributions be made under the terms of the MIT License, http://www.opensource.org/licenses/mit-license.php. Do you agree to the these terms?

Zetten commented 10 years ago

(Just tidied up the commit a bit)

The licensing is all fine on my part. Happy to help out.

Zetten commented 10 years ago

Wait, I just fixed up the wrong branch (a scratch repo on a second machine) so it's back as a new goal rather than a parameter. /sigh

I'll sort it out properly and let you know when it's ready to merge.

Zetten commented 10 years ago

Okay, that's it all sorted out I think. Merge away!

jamezp commented 10 years ago

Merged, thanks!