jbossas / jboss-as-maven-plugin

Maven plugin to deploy applications to JBoss AS 7 (moved to https://github.com/wildfly/wildfly-maven-plugin)
74 stars 69 forks source link

Add classifier property to deploy mojo #98

Open ahaeber opened 7 years ago

ahaeber commented 7 years ago

Deployment fails if a classifier is added to the project artifact's final name. And the deploy mojo does not have properties to specify classifier etc like the run and start mojos.

As a workaround the filename property can be used like: <filename>${project.build.finalName}-${myclassifier}.${project.packaging}</filename>

Here is what Maven says about the finalName currently being used at https://github.com/jbossas/jboss-as-maven-plugin/blob/master/src/main/java/org/jboss/as/plugin/deployment/AbstractAppDeployment.java#L79 :

finalName: This is the name of the bundled project when it is finally built (sans the file extension, for example: my-project-1.0.jar). It defaults to ${artifactId}-${version}. The term "finalName" is kind of a misnomer, however, as plugins that build the bundled project have every right to ignore/modify this name (but they usually do not). For example, if the maven-jar-plugin is configured to give a jar a classifier of test, then the actual jar defined above will be built as my-project-1.0-test.jar.

jamezp commented 7 years ago

I think it's best to stick with the project.getBuild().getFinalName(). It's easily overridden and there is no guarantee that all plugins actually will append the classifier. In most cases I assume it will, but there is no guarantee.

I guess though we could append the classifier and if not found, just use the final name then fail if that's not found.

I'll leave this open for now though. For the most part I'm not adding new features to this plugin, but this could be considered a bug I suppose.