search

jbossdemocentral / coolstore-microservice

CoolStore is a containerised polyglot microservices application consisting of services based on JBoss, NodeJS, Spring Boot, WildFly Swarm, Vert.x, Netflix OSS and more running on OpenShift
299 stars 324 forks source link

jbossdemocentral string is hard-coded so forks don't work #83

Open trepel opened 7 years ago

trepel commented 7 years ago

The jbossdemocentral string is hard-coded in several places accross the code base. It makes the forks of the repo not work as expected.

It is mostly hard-coded in various openshift templates (yaml/json files). One ocurrence is also in coolstore-ui/package.json (not causing issues) and in https://github.com/jbossdemocentral/coolstore-microservice/blob/1.0.x/openshift/scripts/provision-demo.sh#L327 (which I think should be fixed).

siamaksade commented 7 years ago

The provision-script.sh uses the env var GITHUB_ACCOUNT to refer to other repos in case it is forked. The reference you mentioned is a sed command and does not interfere with forks.

What issue did you run into?

trepel commented 7 years ago

Hi @siamaksade, thanks for reply. To be honest I can't remember. Thinking about it again it very well might be that I thought the root cause of issue https://github.com/jbossdemocentral/coolstore-microservice/issues/77 was caused by jbossdemocentral being hard-coded which was not true.

If you or someone else from coolstore developers went through all the jbossdemocentral ocurrences in code base and all occurences seem ok to you, I am not going to argue. Feel free to close this one. I will reprovision from fork and if I encounter something I will create another more specific issue.