search

jbosstools / jbosstools-locus

1 stars 12 forks source link

Preparation for 1.1.1.Final release #35

Closed mickaelistria closed 11 years ago

nickboldt commented 11 years ago

Not a big fan of the idea of single-use "touchMeForNewerTimestamp" files. Can't we just add a newline into MANIFEST.MF or pom.xml files to force jgit to see a change?

mickaelistria commented 11 years ago

@nickboldt I don't like mich the idea of altering an important functional file just to get a new timestamp. FYI, the marker file is the pattern used by Platform (that's not a very good argument, I know)

mickaelistria commented 11 years ago

@nickboldt @maxandersen I edited this commit to change the build.properties files instead of creating new files.

maxandersen commented 11 years ago

looks much nicer and sane now ;)

Platforms approach I guess is relevant because they currently need it more often.

+1 for this.

maxandersen commented 11 years ago

btw. I guess the version should say 1.1.1.Final not 1.1.1-SNAPSHOT?

mickaelistria commented 11 years ago

btw. I guess the version should say 1.1.1.Final not 1.1.1-SNAPSHOT?

That will be part of another commit. I'd like to make at least a SNAPSHOT build before releasing 1.1.1.Final