jbosstools / jbosstools-locus

1 stars 12 forks source link

JBIDE-18721: Adds new Saxon-HE version 9.5.1.6j #36

Closed phantomjinx closed 8 years ago

phantomjinx commented 9 years ago
maxandersen commented 9 years ago

1182 files ? what is so special about this to require all be checkked in when all others dont need it ?

phantomjinx commented 9 years ago

@maxandersen I'm a little confused by your comment. All other components of locus have their src checked in as well! Thus, I simply followed the same template as the previous version of saxon.

As to the requirement, Teiid (as in the server project) have upgraded their dependencies on saxon-he to 9.5.1.6. This latter version is a change in API. Since Designer sources its Teiid client code from the Teiid project, the only way to address changes in API is to upgrade Designer's dependence as well.

maxandersen commented 9 years ago

hmm - you are right. For some reason I was convinced we fetched source from github/mvn coordinates where possible. I guess that was in another reality ;)

maxandersen commented 9 years ago

I'm a bit perplexed since we have the clear goals in the readme.md:

  1. Do not include jars directly into the repository, use Maven coordinates for the build as much as possible.
    • Want to keep the repository lean and clean for easy building and contributions.
  2. Do not build from source, use the already available public binaries.
    • We are not trying to create forks of libraries.

So my question is still, do we really need the source here ?

phantomjinx commented 8 years ago

Out of date