search

jbosstools / jbosstools-locus

1 stars 12 forks source link

JBIDE-19220 add assertj #37

Closed maxandersen closed 4 years ago

maxandersen commented 9 years ago

First try of getting assertj into Locus for better asserts.

@xcoulon please try it out by running 'mvn clean install' and use the 'site/target' in your Tycho built eclipse plugin.

mickaelistria commented 9 years ago

From a build POV, PR seems good. No objection to merge it.

xcoulon commented 9 years ago

@maxandersen @mickaelistria sorry for the delay. I followed your instructions and it worked fine for me on LiveReload: I could finally remove all mvn dependencies (including Mockito). @maxandersen could you update your PR to include a newer version of assertJ ? The latest version that does not require Java 8 is 2.1.0. Starting from version 3.0.0, AssertJ supports Lambda expressions. IF it it is not an issue to use Lambda Expression intest plugins, then I'd love to use AssertJ version 3 ;-)

xcoulon commented 9 years ago

replaced by https://github.com/jbosstools/jbosstools-locus/pull/44