search

jbosstools / jbosstools-locus

1 stars 12 forks source link

LOCUS-43 tycho 0.22; upversion to 1.3; fix missing TP resolution deps #45

Closed nickboldt closed 9 years ago

nickboldt commented 9 years ago

move up to use org.jboss.tools.tycho-plugins 0.22.1-SNAPSHOT and tycho 0.22.0; bump TP version to 1.3 (not 1.0); fix missing dependencies so we can resolve the TP, including sources

nickboldt commented 9 years ago

Comments deleted because they no longer apply. I fixed the issue w/ missing dependencies at TP validation time. :D

Fix: https://github.com/jbosstools/jbosstools-locus/pull/45/files#diff-f26a8a40c6eceb420a99847a51d9a1ecR25

mickaelistria commented 9 years ago

Seems like a good change. Do we need the multiple2repo profile for Locus?

pleacu commented 9 years ago

I need this to proceed with LOCUS-42. Since this is an independent change and needed bug fix - can we proceed with processing this PR?

mickaelistria commented 9 years ago

@pleacu If it's an independent change, why do you need it to be merged first?

nickboldt commented 9 years ago

multiple2repo is needed to make it easier to test the TP & Locus update site combo inside JBTIS. Since there are no objections to this (I see no -1), I will merge this.

mickaelistria commented 9 years ago

Isn't the Locus TP meant to be purely internal? Does JBTIS consume it? What is the user story for JBTIS dev to use multiple2repo ?

nickboldt commented 9 years ago

User story: once upon a time, a user wanted to do local testing to verify that everything could be co-installed from Locus, Locus TP, JBTIS, JBTIS TP, etc. Let's call that user Paul. :D

mickaelistria commented 9 years ago

This user-story ism't valid IMO, there is actually no reason why anyone should care about the Locus TP out of Locus. It's an internal thing, it's never made available for other builds or other installations. cc @pleacu

pleacu commented 9 years ago

Yes - the Locus TP is an internal thing and the build has no requirement to specify -Pmultiple2repo. It's a profile that exists to materialize the repo locally in a convenient way in the event we want to test different local build scenarios.