jbosstools / jbosstools-locus

1 stars 12 forks source link

LOCUS-50 - update to jsonschema2pojo manifest #56

Closed bfitzpat closed 8 years ago

lhein commented 8 years ago

Yeah, that is what I meant when saying its more flexible. Though such flexibility comes at the cost of more risk as other plugins might export those packages too and it gets even worse if 2 of your plugins have to basically use the same bundle which provides those packages due to classloading issues or similar. That can be really nasty.

nickboldt commented 8 years ago

But surely you'll have a consistent TP which only includes one plugin that exports this jaxb stuff? If you won't be consistent in your TP, there's a bigger problem in your code base than whether we use import-package or require-bundle.

It should be noted that while planning for a hypothetical Orbit release is good, since it's hypothetical, maybe using Require-Bundle on Locus bundles isn't really the death sentence it at first could appear to be. :D

pleacu commented 8 years ago

Okay - given that we are pulling from Locus into an aggregated JBTIS TP and then into Fuse Tooling and that there are no Import-Package statement in Locus currently - are we good to get a push and a SNAPSHOT build of Locus?? Maybe a Require-Bundle is more appropriate for Locus?

maxandersen commented 8 years ago

Definitely do a snapshot to try it out.

With respect to require/import package remember your/our features have the final say in what gets included/bundled so we do still have the control - the question is just you want it to be inside Locus or at your or our feature level depending on who packages it up.

I'm just saying that unless you have a hard reason to use require-bundle it should be considered before doing it.

maxandersen commented 8 years ago

that there are no Import-Package statement in Locus currently

FYI - There are also only two Require-Bundle - one for junit that probably could be changed to import-package and one for fastassert that i believe is needed due to hard dependency between the two.

so its not like Require-Bundle is blessed ;)