jbosstools / jbosstools-quarkus

Quarkus tooling for Eclipse

https://tools.jboss.org

Apache License 2.0

16 stars 20 forks source link

JBIDE-27802: JAVA_HOME should not be visible in environment list #146

Closed jeffmaury closed 3 years ago

jeffmaury commented 3 years ago

Signed-off-by: Jeff MAURY jmaury@redhat.com

Pull Request Checklist

General

Is this a blocking issue or new feature? If yes, QE needs to +1 this PR

Code

Are method-/class-/variable-names meaningful?
Are methods concise, not too long?
Are catch blocks catching precise Exceptions only (no catch all)?

Testing

Are there unit-tests?
Are there integration tests (or at least a jira to tackle these)?
Is the non-happy path working, too?
Are other parts that use the same component still working fine?

Function

Does it work?

jeffmaury commented 3 years ago

Please review @olkornii

olkornii commented 3 years ago

@jeffmaury Works for me. JAVA_HOME is not visible anymore.