jbosstools / jbosstools-quarkus

Quarkus tooling for Eclipse
https://tools.jboss.org
Apache License 2.0
16 stars 20 forks source link

JBIDE-28449: Extensions from platform should have an indicator #185

Closed jeffmaury closed 1 year ago

jeffmaury commented 1 year ago

Signed-off-by: Jeff MAURY jmaury@redhat.com

Pull Request Checklist

General

Code

Testing

Function

sbouchet commented 1 year ago

also, is there any example/extension without the icon yet to test ?

jeffmaury commented 1 year ago

also, is there any example/extension without the icon yet to test ?

Quinoa

jeffmaury commented 1 year ago

LGTM, however the icon is still there ?

It should be a different icon. Previously the icon identified extensions that add sample code, now the icon identifies extensions that are part of the platform

sbouchet commented 1 year ago

LGTM, however the icon is still there ?

It should be a different icon. Previously the icon identified extensions that add sample code, now the icon identifies extensions that are part of the platform

yes, i see the new icon in the UI, my remark is more that the old one is still in the source code repo and should be deleted since it is not used anymore :)

jeffmaury commented 1 year ago

LGTM, however the icon is still there ?

It should be a different icon. Previously the icon identified extensions that add sample code, now the icon identifies extensions that are part of the platform

yes, i see the new icon in the UI, my remark is more that the old one is still in the source code repo and should be deleted since it is not used anymore :)

Sorry I pushed my commit to another PR. Fixed now