jbosstools / jbosstools-quarkus

Quarkus tooling for Eclipse
https://tools.jboss.org
Apache License 2.0
16 stars 20 forks source link

Plugin breaks Java/Refactor/Rename shortcut #199

Open Omega1001 opened 1 year ago

Omega1001 commented 1 year ago

After installing Quarkus Tools, the function to reanme Java types/methods etc. using a shortcut no longer works.

If I press ALT+Shift+R before installing, it works normal. After installation, eclipse starts flickering for a few seconds in wich eclipse is completely unusable Then, something that could be a context menu appears for the blink of an eye and that's it.

I tried to unbind whatever function is not properly going using Preferences/General/Keys, but it doesnt show any bound shortcuts for anything but the standards for that combination. Even unbinding all other chooses did not resolve the program.

I traced the source to quarkus tools by doing a step by step setup, checking after every step, if it was working properly.

Eclipse Version is: Version: 2022-09 (4.25.0) Build id: 20220908-1902

Quarkus Tools Version is: 1.8.0.v20220927-1329

angelozerr commented 1 year ago

This issue comes from LSP4E which define a rename handler at https://github.com/eclipse/lsp4e/blob/05845909cc6bf621aa88d36e15b35ee350c5cfa3/org.eclipse.lsp4e/plugin.xml#L103 when a file is mapped to a language server.

It works great with generic editor, but I suspect that there is a problem with Java Editor usecase. Java Editor provides a rename handler for Java files in JDT and in JBoss Quarkus usecase, it adds a rename handler too.

I suggest that you move to this issue to LSP4E.