jbosstools / jbosstools-quarkus

Quarkus tooling for Eclipse

https://tools.jboss.org

Apache License 2.0

16 stars 20 forks source link

JBIDE-28859: fix quarkus tests #203

Closed sbouchet closed 1 year ago

sbouchet commented 1 year ago

Signed-off-by: Stephane Bouchet sbouchet@redhat.com

Pull Request Checklist

General

Is this a blocking issue or new feature? If yes, QE needs to +1 this PR

Code

Are method-/class-/variable-names meaningful?
Are methods concise, not too long?
Are catch blocks catching precise Exceptions only (no catch all)?

Testing

Are there unit-tests?
Are there integration tests (or at least a jira to tackle these)?
Is the non-happy path working, too?
Are other parts that use the same component still working fine?

Function

Does it work?

angelozerr commented 1 year ago

The CI build fails. Could you please remove https://github.com/jbosstools/jbosstools-quarkus/blob/main/tests/org.jboss.tools.quarkus.lsp4e.test/projects/maven/rest-client-quickstart/src/main/resources/application.properties in your PR.