jbosstools / jbosstools-server

JBoss Tools :: Server { archives, as, jmx, wtp }

4 stars 58 forks source link

JBIDE-28394: proper dispose of SWT resources #758

Closed sbouchet closed 2 years ago

sbouchet commented 2 years ago

Signed-off-by: Stephane Bouchet sbouchet@redhat.com

Pull Request Checklist

General

Is this a blocking issue or new feature? If yes, QE needs to +1 this PR

Code

Are method-/class-/variable-names meaningful?
Are methods concise, not too long?
Are catch blocks catching precise Exceptions only (no catch all)?

Testing

Are there unit-tests?
Are there integration tests (or at least a jira to tackle these)?
Is the non-happy path working, too?
Are other parts that use the same component still working fine?

Function

Does it work?