jbosstools / jbosstools-server

JBoss Tools :: Server { archives, as, jmx, wtp }
4 stars 58 forks source link

Fixes #799 - add rsp server feature #800

Closed robstryker closed 1 year ago

robstryker commented 1 year ago

Pull Request Checklist

General

Code

Testing

Function

sbouchet commented 1 year ago

first comment about general usage of the view. below is the some screenshots of my tests. Capture d’écran du 2023-08-31 11-24-48 Capture d’écran du 2023-08-31 11-25-07 Capture d’écran du 2023-08-31 11-25-31 Capture d’écran du 2023-08-31 11-26-17 Capture d’écran du 2023-08-31 11-26-43 Capture d’écran du 2023-08-31 11-28-13

sbouchet commented 1 year ago

first comment about general usage of the view. below is the some screenshots of my tests. Capture d’écran du 2023-08-31 11-24-48 Capture d’écran du 2023-08-31 11-25-07

those are ok.

sbouchet commented 1 year ago

Capture d’écran du 2023-08-31 11-25-31

here the list is cropped at the very end.

sbouchet commented 1 year ago

Capture d’écran du 2023-08-31 11-26-17

is the secure storage pop pu is mandatory ? the text box is too short, please use all the space.

sbouchet commented 1 year ago

Capture d’écran du 2023-08-31 11-26-43 Capture d’écran du 2023-08-31 11-28-13

those two have some background issues and labels are not centered with the text boxes.

robstryker commented 1 year ago

Capture d’écran du 2023-08-31 11-26-17

is the secure storage pop pu is mandatory ? the text box is too short, please use all the space.

I'll try to use all the space.

Whether this specific prompt is necessary is more a question about the underlying RPS. The UI is just responding to a request for prompt from the background RSP and must display it.

robstryker commented 1 year ago

Capture d’écran du 2023-08-31 11-26-43 Capture d’écran du 2023-08-31 11-28-13

those two have some background issues and labels are not centered with the text boxes.

Looks fine in light mode, but not dark mode. Wonder what's wrong here.

robstryker commented 1 year ago

Looks fine in light mode, but not dark mode. Wonder what's wrong here.

Seems the styling matches on class names somehow, and extending "Composite" is frowned upon. Converting my composite subclasses to just be a kind of wrapper instead seems to fix it.