search

jbosstools / m2e-apt

Maven integration with Eclipse JDT Annotation Processor Toolkit
39 stars 19 forks source link

Do not change .factorypath if it is already present #40

Open WonderCsabo opened 9 years ago

WonderCsabo commented 9 years ago

In some cases, projects needs a .factorypath, because it is customized. For example they could need an Eclipse plugin as an annotation processor in Eclipse builds, which cannot be added by m2e-apt. I think m2e-apt could use a new GUI option: "Do not change factory path if it is already present". The default value can be false. @fbricon WDYT?

WonderCsabo commented 9 years ago

To tell you an actual use-case:

this is a common setup for annotation processor development, you start a second eclipse instance and modify the test project in it, and if you use the AP as an Eclipse plugin in the second instance, you can nicely debug the AP in the first instance, use hot-code replacement, even JRebel etc.

fbricon commented 9 years ago

Looks like some people want the opposite behavior (issue #28)

So why not disable m2e-apt for your project? it'll use whatever .factorypath you already have. You can use:

<m2e.apt.activation>disabled<m2e.apt.activation>

WonderCsabo commented 9 years ago

@fbricon i still want to use m2e-apt for:

fbricon commented 9 years ago

on pto with extremely limited internet access. you can submit a pr and I will take a look in at most 2 weeks

WonderCsabo commented 9 years ago

@fbricon that is cool, thanks for your response!

WonderCsabo commented 9 years ago

@fbricon i am afraid i have to resign from this. I am really not familiar with Eclipse UI coding, and i do not have the time to learn it. Also, i have to admit, this issue is now lower priority for me than before.

mickaelistria commented 2 years ago

m2e-apt's code is now included in https://github.com/eclipse-m2e/m2e-core , please consider reporting issue to https://github.com/eclipse-m2e/m2e-core/issues if it's still relevant.