Closed lefou closed 6 years ago
@lefou I'll review/test later today, hopefully
I finally had a chance to take a look at it, sorry it took so long.
Ideally, the plugin version should be set per project, instead of per workspace but this is more of a power user feature so I can live with that.
If you could just please squash your commits and add a signed-off-by mention (git commit -s), we could move forward.
I agree that this should be a per workspace setting, but as you said, it's a seldom used power user feature (I expect to use this feature only until the next polyglot-scala release) and this is a POC project.
@fbricon Can you tell me, what is missing to move forward? I already squashed and signed the commit.
Also, this patch currently allows me to use polyglot 0.3 which comes with incompatible API for Scala. But it also allows to use an older version explicitly.
Comment edited to not sound offensive.
Sorry I completely missed the previous notifications. I tested without the version, to convert to a groovy pom, and I got polyglot-groovy:0.3.0. So is this feature still relevant?
Yes. Without, I can't use SNAPSHOT or older versions.
Thanks!
Adds an extra preferences field were the user can select the used version of the internally used plugin.
This change was essential for me to test and work with a new and unreleased feature of polyglot-maven. That way, I can set a SNAPSHOT-version from my local repository.