jbosstools / m2e-polyglot-poc

M2E Polyglot Support Experiment
Eclipse Public License 1.0
15 stars 8 forks source link

Configurable version of internally used polyglot-translate-plugin #11

Closed lefou closed 6 years ago

lefou commented 6 years ago

Adds an extra preferences field were the user can select the used version of the internally used plugin.

This change was essential for me to test and work with a new and unreleased feature of polyglot-maven. That way, I can set a SNAPSHOT-version from my local repository.

fbricon commented 6 years ago

@lefou I'll review/test later today, hopefully

fbricon commented 6 years ago

I finally had a chance to take a look at it, sorry it took so long.

Ideally, the plugin version should be set per project, instead of per workspace but this is more of a power user feature so I can live with that.

If you could just please squash your commits and add a signed-off-by mention (git commit -s), we could move forward.

lefou commented 6 years ago

I agree that this should be a per workspace setting, but as you said, it's a seldom used power user feature (I expect to use this feature only until the next polyglot-scala release) and this is a POC project.

lefou commented 6 years ago

@fbricon Can you tell me, what is missing to move forward? I already squashed and signed the commit.

Also, this patch currently allows me to use polyglot 0.3 which comes with incompatible API for Scala. But it also allows to use an older version explicitly.

Comment edited to not sound offensive.

fbricon commented 6 years ago

Sorry I completely missed the previous notifications. I tested without the version, to convert to a groovy pom, and I got polyglot-groovy:0.3.0. So is this feature still relevant?

lefou commented 6 years ago

Yes. Without, I can't use SNAPSHOT or older versions.

lefou commented 6 years ago

Thanks!