jbostoen / iTop-custom-extensions

Extensions for iTop . New classes (SIM cards, Monitors, IP Devices), more powerful Mail to Ticket automation, basic info on pro extensions such as geometry and ticket merge, some concepts (Check Out system), several small tweaks.
GNU General Public License v3.0
36 stars 13 forks source link

jb-ssid: dependency of itop-request-mgmt-itil #26

Closed jaroslavsafranek closed 4 years ago

jaroslavsafranek commented 4 years ago

Type: issue

Version info:

iTop version 2.7.0-beta2-5120 built on 2020-01-29 12:01:24 Data model: 2.7.0-beta2 MySQL: 10.1.41-MariaDB-0+deb9u1 PHP: 7.2.27-1+0

Description: Hi, I try your data model jb-ssid install on our instance of iTop and I see this:

The following modules have unmet dependencies: Datamodel: SSID - wireless networks documentation (id: jb-ssid/2.6.200123) depends on itop-request-mgmt-itil/2.6.0

I know that our version is 2.7, but I think that problem is about using itop-request-mgmt (simple request managmet). Can you try fix it for using both: simple and ITIL?

Thanks Jaroslav

piRGoif commented 4 years ago

One way to achieve this is to use the || operator. Example :

        'dependencies' => array(
            'itop-request-mgmt/2.7.0||itop-request-mgmt-itil/2.7.0||itop-portal-base/2.7.0',
        ),
jbostoen commented 4 years ago

You are likely using the non ITIL version. Feel free to fork and create your own version.

jbostoen commented 4 years ago

Hm, thanks Pierre!

Might revise it if it's that easy Also might see if this requirement is actually necessary

piRGoif commented 4 years ago

This is used in numerous Combodo modules : Dispatch of User Request, SLA computation with coverage windows for UserRequest and Incidents, Approval light (on user requests), ...

jbostoen commented 4 years ago

I have yet to check if there are any downsides, for now I removed the dependency completely.

I don't recall why the dependency is, if it's a leftover from a copy-paste job or from an original idea.