Open justyn opened 3 years ago
stage 1:
NO_EXISTING_FOOTPRINT
stage 2:
stage 3: PR link: https://github.com/jbots/kicad-jb-public/pull/27
stage 4:
NO_IGNORE
stage 5:
.pretty
directory (for a footprint)Then:
Link to footprint pull request : https://github.com/KiCad/kicad-footprints/pull/2480
stage 6:
Each time you push changes to the pull request:
Please check or create this footprint:
Osram SideLED 3010 from https://dammedia.osram.info/media/resource/hires/osram-dam-4861654/LB%20Y8SG_EN.pdf
Stages
This ticket will track the six stages of making the part(s).
Each time you start a new stage, please cut and paste the comment box for that stage into a new comment. After submitting the comment use your mouse to click the tickboxes, and use the "edit" button the comment to fill in the answers as you go. Please don't create duplicate comments.
Stage 1: Check for symbols and footprints in official libraries
Check for existing parts in kicad-footprints
Cut and paste comment box for stage 1:
Stage 2: Create/modify required parts
Cut and paste comment box for stage 2:
Stage 3: Create pull request in kicad-jb-public
Footprints:
.kicad_mod
file directly in theJB.pretty
directory (and not in any subdirectory)fp.pretty/QFN-28_4x4mm_P0.5mm.kicad_mod
Create a pull request (PR) in kicad-jb-public (this repository) with the part number in the title. Make sure your branch is up to date with the repository first.
Cut and paste comment box for stage 3:
Stage 4: Make any changes to allow merging into this repository
Automatic checks will be run when you create your pull request in this repository.
The parts have not passed until you see "Check footprint name" next to the name of each footprint you have created, with a green tick.
The Kicad Library Conventions can be found here.
Any KLC rule failures must be fixed. Click on "Details" next to the failing rule for more information. If the automatic check should be ignored in this specific case, explain it below.
Important: Not all rules have an automatic test, so a part passing does not mean that it doesn't violate any rules.
Cut and paste comment box for stage 4:
Stage 5: Create pull requests in kicad official libraries
Create a pull request in kicad-footprints
Cut and paste comment box for stage 5:
Stage 6: Make required changes for parts to be merged in official libraries
At the bottom of the PR in kicad-footprints, click "Details" next to "continuous-integration/travis-ci/pr" to see any automatic recommendations for fixes to the parts.
Make any changes requested by the Kicad librarians.
Do not request a review, or send comments asking for your part to be checked. If nobody is checking the part, add more details to the pull request, including screenshots from the datasheet (of pin tables, package dimensions etc).
Cut and paste comment box for stage 6: