search

jboullion / rad-toolkit

Application for listing aerospace component properties with a focus on their radiation resistance
https://rad-toolkit.nexusaurora.org/
1 stars 0 forks source link

Database type and component limits #18

Closed jboullion closed 1 year ago

jboullion commented 1 year ago

I believe "forward_voltage" and "forward_current" are spelled "foward_current" and "foward_current" in DB.

I updated the max return from 50 to 200. Could also just list everything no matter how many, but that can sometimes lead to problems. The other option is to implement pagination, which we can do, but would rather not. Hopefully 200 is good enough for now. More than that and they will probably want / need to be filtering anyway :)

I updated the suffix for the three new properties. I have no idea what those words mean so let me know if the suffixes are incorrect.

codeflight1 commented 1 year ago

That's correct, I have fixed the naming.

The suffixes are almost correct, but the values are being compressed down into integers. We need to properly handle things such as millivolts and milliamps, similar to the memory sizes.

jboullion commented 1 year ago

Updated suffix! Commit

codeflight1 commented 1 year ago

LGTM