jbouzekri / PhumborBundle

A bridge for symfony with the phumbor client from 99designs
MIT License
25 stars 9 forks source link

Allow overriding transformation definitions in later config files #17

Closed mpdude closed 3 years ago

mpdude commented 3 years ago

When transformations are re-defined/overridden by their name in later config files, the later definition should completely replace the first one. Here's an example:

# config.yml

jb_phumbor:
    transformations:
        test_overridden:
            filters:
                - { name: 'quality', arguments: [ 60 ] }
            resize: { width: 100, height: 100 }
        test_not_overridden:
            resize: { width: 100, height: 100 }
# config_development.yml

imports:
    - { resource: config.yml }

jb_phumbor:
    transformations:
        test_overridden:
            resize: { width: 200, height: 200 }

... then the resulting config should have test_not_overridden as provided, and test_overridden consist of the "resize" operation (200x200) only.

mpdude commented 3 years ago

@jbouzekri Travis failures in PHP 7.3 and 7.4 seem to be due to a Travis CI/php.ini misconfiguration,

Code coverage needs to be enabled in php.ini by setting 'xdebug.mode' to 'coverage'

Maybe you can help?

jbouzekri commented 3 years ago

@mpdude : new release https://github.com/jbouzekri/PhumborBundle/releases/tag/2.2.0