search

jbouzekri / PhumborBundle

A bridge for symfony with the phumbor client from 99designs
MIT License
25 stars 9 forks source link

Symfony7, PHP 8.3 #24

Closed hovorma closed 5 months ago

hovorma commented 10 months ago

Hello, I am using actively using your bundle in my projects. Currently, I am working with Symfony 7 with PHP 8.3, it seems the bundle is not compatible yet with them, are you going to update it?

jbouzekri commented 10 months ago

Hi @hovorma, first of all, thank you for using my bundle. I would be happy to merge any MR adding this level of compatibility. I have not followed the latest changes neither in the PHP language or the Symfony framework so I cannot say how difficult it would be (for example if I am using some deprecated features that have been removed in these versions). But maybe just adding the new versions to the composer.json for php and symfony could be enough : https://github.com/jbouzekri/PhumborBundle/blob/master/composer.json

hovorma commented 10 months ago

hi @jbouzekri, thanks a lot for your answer. It gives an error in the bundle configuration tree. maybe Symfony changed a bit structure of the configs.

jbouzekri commented 10 months ago

@hovorma : can you post the exception please ?

hovorma commented 10 months ago

image

sure, after the "composer require" of your bundle, during cache:clear I get this error

jbouzekri commented 9 months ago

@hovorma : can you test the branch https://github.com/jbouzekri/PhumborBundle/tree/feat-sf7 ? If it works for you, I will merge it and tag a new release.

jbouzekri commented 5 months ago

Thanks @FabianSchmick

@hovorma : 3.2.0 version released with the #25 MR.