[WIP] Allow to pass callable as argument of CodeDefinitionBuilder::setOptionValidator/setBodyValidator()

jbowens / jBBCode

A lightweight but extensible BBCode parser

http://jbbcode.com

MIT License

164 stars 32 forks source link

[WIP] Allow to pass callable as argument of CodeDefinitionBuilder::setOptionValidator/setBodyValidator() #61

Closed Kubo2 closed 4 years ago

Kubo2 commented 9 years ago

This is an implementation of the proposal #60.

[x] implement ability to pass callables to setOptionValidator()/setBodyValidator()
[x] refactor the code to match coding style
[ ] add tests

This change is

Kubo2 commented 9 years ago

@jbowens Should I also fix the coding style for CallableValidatorAdapter.php or is it all well? Please could you review this?

DaSourcerer commented 8 years ago

Shouldn't I split this into two separate commits, one with implementation, and one containing test case?

A bit late perhaps, but: PRs are ideally atomic. That is they contain the desired changes as well as additional tests to demonstrate the intended behaviour. Splitting code changes and tests into two PRs will also defeat the purpose of the CI.