jbowens / jBBCode

A lightweight but extensible BBCode parser
http://jbbcode.com
MIT License
164 stars 32 forks source link

Fix getAttribute return type #82

Closed shmax closed 5 years ago

shmax commented 5 years ago

I've been working with a static type checker on my code base, and the return type of ElementNode::getAttribute is causing some problems. It's annotated as string[], but it's actually an associative array.

@DaSourcerer I also need your other PHPDoc fixes, but they haven't been tagged with a release. I get the sense this is a dead project; any interest in publishing your own fork?

Art4 commented 5 years ago

@shmax

I get the sense this is a dead project; any interest in publishing your own fork?

I would be interested too.

shmax commented 5 years ago

@DaSourcerer Anybody home?

jbowens commented 5 years ago

Hey y'all. As you've noticed, I don't actively maintain the project anymore. I haven't written php in earnest in many years, and I'm pretty rusty. I don't feel comfortable merging any significant features or refactors. I'm happy to merge small easy-to-review PRs, but I can't invest any significant time into the project.

If you need anything specific from me, just ask. If you want to fork and maintain the project, that'd be great too.

shmax commented 5 years ago

@jbowens Good to hear from you! Sorry to run an end zone around you like that--I honestly kind of thought you might be dead, or worse, retired. Tell you what, if you'll tag a new release I'll clam up for now and we can talk about transferring activity to a fork for next time...

jbowens commented 5 years ago

So I actually don't have access to the package on packagist, so I don't think I can cut a new release 😬 . I'm not sure who registered the package on packagist, but I don't think it was me. Unfortunately, authing with GitHub doesn't seem to be sufficient to get access. I emailed them, and I'll see what they say.

shmax commented 5 years ago

I don't think I can cut a new release

If everything is set up properly on packagist you don't need to do anything; just make a new release here on the repo and the rest should happen naturally.

Art4 commented 5 years ago

I'm not sure who registered the package on packagist

This must be @Fale

Fale commented 5 years ago

@jbowens I'm not really sure why I have it. I can give you maintership status, if you give me your packagist username!

shmax commented 5 years ago

Thanks for merging, but it looks like the new release in fact didn't reflect on packagist, at least not yet. Maybe something to do with the broken build?

jbowens commented 5 years ago

@Fale I'm jbowens on packagist as well: https://packagist.org/users/jbowens/

DaSourcerer commented 5 years ago

@DaSourcerer Anybody home?

To break the radio silence: Yes, I am still around. Booked solid, though. I do not see that changing before mid-April, early May.

If I can make it, I'll take a look at the Travis CI setup this weekend. No promises, though.

Fale commented 5 years ago

@jbowens you now have the maintainership access :)