jbowensii / More-Automated-Spells-Items-and-Feats

FoundryVTT More Automated Spells Items and Feats (MASIF amounts of automation)
MIT License
5 stars 3 forks source link

Precision Attack dice roll #7

Open YenBenGrey opened 1 year ago

YenBenGrey commented 1 year ago

With Precision Attack the description states that you can make a decision before or after the roll of the D20.

The window that pops up does not tell you the result of the D20, the player needs to keep an eye on the dice.

It isn't a major problem however just thought I would mention it. Unless there is something in maybe Midi I can tweak so they can see the number after the roll? In the pop up window.

BalrogTaco commented 1 year ago

I have a modified version that shows the roll. But it also has a few other changes, so it may or may not work for you. Change the attached file to .json to import it if you would like to try it out fvtt-Item-maneuvers_-precision-attack.txt

YenBenGrey commented 1 year ago

What I’ve done for now is set the time it takes for Dice so Nice to hide the dice for that one player to about 6 seconds. So they shouldn’t miss it. However I will give this a go. Thank you.

YenBenGrey commented 1 year ago

So far the above is amazing.

Is it supposed to not pop up if the attack hits, because that is brilliant. And it says if the attack will MISS. One of the concerns from the player is that it pops up when not needed.

jbowensii commented 1 year ago

thank you [BalrogTaco] I will incorporate your changes this week and give you credit. :)

BalrogTaco commented 1 year ago

@YenBenGrey yes it is supposed to not show the dialog if you hit or if you are out of superiority dice (as tracked as a resource, not as another feat as some importers set up the resource)

@jbowensii hope it helps. I think I have a few others of yours that I worked on as well, I suppose i should have made a PR

jbowensii commented 1 year ago

please send them over I will adjust and list you in the credits on the code and for the module..