search

jboxberger / synology-gitlab

Updated an improved Original Synology Package
MIT License
129 stars 19 forks source link

Update from 12.7.5-005 to 12.9.2-0055 fails #43

Closed jirsbek closed 4 years ago

jirsbek commented 4 years ago

First of all, thank you for your time you give to this repo.

Unfortunately I'm experiencing some update fail.

I'm updating GitLab through Package Center. Uploading the SPK goes well, info before the update shows correct version so I hit Update button and after few minutes update fails with no other message.

Package label shows error and newer version as seen on screenshot:

Screenshot 2020-04-20 at 11 46 25

What I've tried:

GitLab Docker container works well (showing and running 12.7.5).

jboxberger commented 4 years ago

Hi jirsbek,

If you haven backed up your data before the update (take this as lesson :-)), please backup your gitlab data dir (default: /volume1/docker/gitlab) now so we do not destroy your data completely while messing around. I've checked the file integrity and the Update process again and on my environment everything works fine, so we have to check what was wrong with you update.

1) Could you please provide your DSM Version. 2) Could you please provide your Docker Version. 3) Could you please provide the update logs

Search for the update records, should be at the bottom an look like this:

2020/04/20 12:46:14     upgrade Docker-GitLab: begin to stop version 12.7.5-0055
...
2020/04/20 12:49:56     install Docker-GitLab: begin to start version 12.9.2-0055
2020/04/20 12:49:56     install Docker-GitLab: start version 12.9.2-0055 successfully, result 0

Your Docker Containers should look like this. Could you please screenshot you current state, grafik

jirsbek commented 4 years ago

Hello jboxberger, your reaction was so fast! Hey, do not forget you do not have to. I mean this is just your voluntary project and not a full time job 😉

Anyway:

  1. My DSM is up to date (6.2.2-24922 Update 4)
  2. Docker version 18.09.0-0506
2020/04/20 09:05:51 stop Docker-GitLab: begin to stop version 12.7.5-0055
2020/04/20 09:05:52 stop Docker-GitLab 12.7.5-0055 Begin start-stop-status stop
2020/04/20 09:06:07 stop Docker-GitLab 12.7.5-0055 End start-stop-status stop ret=[0]
2020/04/20 09:06:07 stop Docker-GitLab 12.7.5-0055 Begin unload apparmor
2020/04/20 09:06:07 stop Docker-GitLab 12.7.5-0055 End unload apparmor ret=[0]
2020/04/20 09:06:07 stop Docker-GitLab: stop version 12.7.5-0055 successfully, result 0
2020/04/20 10:48:25 upgrade Docker-GitLab 12.7.5-0055 Begin preupgrade
2020/04/20 10:48:28 upgrade Docker-GitLab 12.7.5-0055 End preupgrade ret=[0]
2020/04/20 10:48:28 upgrade Docker-GitLab 12.7.5-0055 Begin preuninst
2020/04/20 10:48:28 upgrade Docker-GitLab 12.7.5-0055 End preuninst ret=[0]
2020/04/20 10:48:28 upgrade Docker-GitLab 12.7.5-0055 Begin /bin/rm -rf /volume1/@appstore/Docker-GitLab
2020/04/20 10:48:28 upgrade Docker-GitLab 12.7.5-0055 End /bin/rm -rf /volume1/@appstore/Docker-GitLab ret=[0]
2020/04/20 10:48:28 upgrade Docker-GitLab 12.7.5-0055 Begin postuninst
2020/04/20 10:48:28 upgrade Docker-GitLab 12.7.5-0055 End postuninst ret=[2]
2020/04/20 10:48:28 upgrade Docker-GitLab: Uninstall 12.7.5-0055 successfully
2020/04/20 10:48:28 upgrade Docker-GitLab 12.9.2-0055 Begin preinst
2020/04/20 10:48:28 upgrade Docker-GitLab 12.9.2-0055 End preinst ret=[0]
2020/04/20 10:48:28 upgrade Docker-GitLab 12.9.2-0055 Begin /bin/mv -f /volume1/@tmp/pkginstall/package /volume1/@appstore/Docker-GitLab
2020/04/20 10:48:28 upgrade Docker-GitLab 12.9.2-0055 End /bin/mv -f /volume1/@tmp/pkginstall/package /volume1/@appstore/Docker-GitLab ret=[0]
2020/04/20 10:48:29 upgrade Docker-GitLab 12.9.2-0055 Begin /bin/mkdir -p /var/packages/Docker-GitLab
2020/04/20 10:48:29 upgrade Docker-GitLab 12.9.2-0055 End /bin/mkdir -p /var/packages/Docker-GitLab ret=[0]
2020/04/20 10:48:29 upgrade Docker-GitLab 12.9.2-0055 Begin /bin/mv -f /volume1/@tmp/pkginstall/INFO /var/packages/Docker-GitLab/INFO
2020/04/20 10:48:29 upgrade Docker-GitLab 12.9.2-0055 End /bin/mv -f /volume1/@tmp/pkginstall/INFO /var/packages/Docker-GitLab/INFO ret=[0]
2020/04/20 10:48:29 upgrade Docker-GitLab 12.9.2-0055 Begin /bin/rm -rf /var/packages/Docker-GitLab/scripts
2020/04/20 10:48:29 upgrade Docker-GitLab 12.9.2-0055 End /bin/rm -rf /var/packages/Docker-GitLab/scripts ret=[0]
2020/04/20 10:48:29 upgrade Docker-GitLab 12.9.2-0055 Begin /bin/mv -f /volume1/@tmp/pkginstall/scripts /var/packages/Docker-GitLab/scripts
2020/04/20 10:48:29 upgrade Docker-GitLab 12.9.2-0055 End /bin/mv -f /volume1/@tmp/pkginstall/scripts /var/packages/Docker-GitLab/scripts ret=[0]
2020/04/20 10:48:29 upgrade Docker-GitLab 12.9.2-0055 Begin /bin/rm -rf /var/packages/Docker-GitLab/WIZARD_UIFILES
2020/04/20 10:48:29 upgrade Docker-GitLab 12.9.2-0055 End /bin/rm -rf /var/packages/Docker-GitLab/WIZARD_UIFILES ret=[0]
2020/04/20 10:48:29 upgrade Docker-GitLab 12.9.2-0055 Begin /bin/mv -f /volume1/@tmp/pkginstall/WIZARD_UIFILES /var/packages/Docker-GitLab/WIZARD_UIFILES
2020/04/20 10:48:29 upgrade Docker-GitLab 12.9.2-0055 End /bin/mv -f /volume1/@tmp/pkginstall/WIZARD_UIFILES /var/packages/Docker-GitLab/WIZARD_UIFILES ret=[0]
2020/04/20 10:48:29 upgrade Docker-GitLab 12.9.2-0055 Begin /bin/rm -rf /var/packages/Docker-GitLab/conf
2020/04/20 10:48:29 upgrade Docker-GitLab 12.9.2-0055 End /bin/rm -rf /var/packages/Docker-GitLab/conf ret=[0]
2020/04/20 10:48:29 upgrade Docker-GitLab 12.9.2-0055 Begin /bin/mv -f /volume1/@tmp/pkginstall/conf /var/packages/Docker-GitLab/conf
2020/04/20 10:48:29 upgrade Docker-GitLab 12.9.2-0055 End /bin/mv -f /volume1/@tmp/pkginstall/conf /var/packages/Docker-GitLab/conf ret=[0]
2020/04/20 10:48:29 upgrade Docker-GitLab 12.9.2-0055 Begin postinst
2020/04/20 10:53:18 upgrade Docker-GitLab 12.9.2-0055 End postinst ret=[2]
2020/04/20 10:53:18 upgrade Docker-GitLab from 12.7.5-0055 to 12.9.2-0055 failed
2020/04/20 10:53:18 upgrade Docker-GitLab 12.9.2-0055 Begin /bin/rm -rf /volume1/@tmp/pkginstall
2020/04/20 10:53:18 upgrade Docker-GitLab 12.9.2-0055 End /bin/rm -rf /volume1/@tmp/pkginstall ret=[0]
2020/04/20 11:02:07 upgrade Docker-GitLab 12.9.2-0055 Begin preupgrade
2020/04/20 11:02:08 upgrade Docker-GitLab 12.9.2-0055 End preupgrade ret=[0]
2020/04/20 11:02:08 upgrade Docker-GitLab 12.9.2-0055 Begin preuninst
2020/04/20 11:02:08 upgrade Docker-GitLab 12.9.2-0055 End preuninst ret=[0]
2020/04/20 11:02:09 upgrade Docker-GitLab 12.9.2-0055 Begin /bin/rm -rf /volume1/@appstore/Docker-GitLab
2020/04/20 11:02:09 upgrade Docker-GitLab 12.9.2-0055 End /bin/rm -rf /volume1/@appstore/Docker-GitLab ret=[0]
2020/04/20 11:02:09 upgrade Docker-GitLab 12.9.2-0055 Begin postuninst
2020/04/20 11:02:09 upgrade Docker-GitLab 12.9.2-0055 End postuninst ret=[2]
2020/04/20 11:02:09 upgrade Docker-GitLab: Uninstall 12.9.2-0055 successfully
2020/04/20 11:02:09 upgrade Docker-GitLab 12.9.2-0055 Begin preinst
2020/04/20 11:02:09 upgrade Docker-GitLab 12.9.2-0055 End preinst ret=[0]
2020/04/20 11:02:09 upgrade Docker-GitLab 12.9.2-0055 Begin /bin/mv -f /volume1/@tmp/pkginstall/package /volume1/@appstore/Docker-GitLab
2020/04/20 11:02:09 upgrade Docker-GitLab 12.9.2-0055 End /bin/mv -f /volume1/@tmp/pkginstall/package /volume1/@appstore/Docker-GitLab ret=[0]
2020/04/20 11:02:09 upgrade Docker-GitLab 12.9.2-0055 Begin /bin/mkdir -p /var/packages/Docker-GitLab
2020/04/20 11:02:09 upgrade Docker-GitLab 12.9.2-0055 End /bin/mkdir -p /var/packages/Docker-GitLab ret=[0]
2020/04/20 11:02:09 upgrade Docker-GitLab 12.9.2-0055 Begin /bin/mv -f /volume1/@tmp/pkginstall/INFO /var/packages/Docker-GitLab/INFO
2020/04/20 11:02:09 upgrade Docker-GitLab 12.9.2-0055 End /bin/mv -f /volume1/@tmp/pkginstall/INFO /var/packages/Docker-GitLab/INFO ret=[0]
2020/04/20 11:02:09 upgrade Docker-GitLab 12.9.2-0055 Begin /bin/rm -rf /var/packages/Docker-GitLab/scripts
2020/04/20 11:02:09 upgrade Docker-GitLab 12.9.2-0055 End /bin/rm -rf /var/packages/Docker-GitLab/scripts ret=[0]
2020/04/20 11:02:09 upgrade Docker-GitLab 12.9.2-0055 Begin /bin/mv -f /volume1/@tmp/pkginstall/scripts /var/packages/Docker-GitLab/scripts
2020/04/20 11:02:09 upgrade Docker-GitLab 12.9.2-0055 End /bin/mv -f /volume1/@tmp/pkginstall/scripts /var/packages/Docker-GitLab/scripts ret=[0]
2020/04/20 11:02:09 upgrade Docker-GitLab 12.9.2-0055 Begin /bin/rm -rf /var/packages/Docker-GitLab/WIZARD_UIFILES
2020/04/20 11:02:09 upgrade Docker-GitLab 12.9.2-0055 End /bin/rm -rf /var/packages/Docker-GitLab/WIZARD_UIFILES ret=[0]
2020/04/20 11:02:09 upgrade Docker-GitLab 12.9.2-0055 Begin /bin/mv -f /volume1/@tmp/pkginstall/WIZARD_UIFILES /var/packages/Docker-GitLab/WIZARD_UIFILES
2020/04/20 11:02:09 upgrade Docker-GitLab 12.9.2-0055 End /bin/mv -f /volume1/@tmp/pkginstall/WIZARD_UIFILES /var/packages/Docker-GitLab/WIZARD_UIFILES ret=[0]
2020/04/20 11:02:09 upgrade Docker-GitLab 12.9.2-0055 Begin /bin/rm -rf /var/packages/Docker-GitLab/conf
2020/04/20 11:02:09 upgrade Docker-GitLab 12.9.2-0055 End /bin/rm -rf /var/packages/Docker-GitLab/conf ret=[0]
2020/04/20 11:02:09 upgrade Docker-GitLab 12.9.2-0055 Begin /bin/mv -f /volume1/@tmp/pkginstall/conf /var/packages/Docker-GitLab/conf
2020/04/20 11:02:09 upgrade Docker-GitLab 12.9.2-0055 End /bin/mv -f /volume1/@tmp/pkginstall/conf /var/packages/Docker-GitLab/conf ret=[0]
2020/04/20 11:02:10 upgrade Docker-GitLab 12.9.2-0055 Begin postinst
2020/04/20 11:04:29 upgrade Docker-GitLab 12.9.2-0055 End postinst ret=[2]
2020/04/20 11:04:29 upgrade Docker-GitLab from 12.9.2-0055 to 12.9.2-0055 failed
2020/04/20 11:04:29 upgrade Docker-GitLab 12.9.2-0055 Begin /bin/rm -rf /volume1/@tmp/pkginstall
2020/04/20 11:04:30 upgrade Docker-GitLab 12.9.2-0055 End /bin/rm -rf /volume1/@tmp/pkginstall ret=[0]
2020/04/20 11:34:23 upgrade Docker-GitLab 12.9.2-0055 Begin preupgrade
2020/04/20 11:34:24 upgrade Docker-GitLab 12.9.2-0055 End preupgrade ret=[0]
2020/04/20 11:34:24 upgrade Docker-GitLab 12.9.2-0055 Begin preuninst
2020/04/20 11:34:24 upgrade Docker-GitLab 12.9.2-0055 End preuninst ret=[0]
2020/04/20 11:34:24 upgrade Docker-GitLab 12.9.2-0055 Begin /bin/rm -rf /volume1/@appstore/Docker-GitLab
2020/04/20 11:34:24 upgrade Docker-GitLab 12.9.2-0055 End /bin/rm -rf /volume1/@appstore/Docker-GitLab ret=[0]
2020/04/20 11:34:25 upgrade Docker-GitLab 12.9.2-0055 Begin postuninst
2020/04/20 11:34:25 upgrade Docker-GitLab 12.9.2-0055 End postuninst ret=[2]
2020/04/20 11:34:25 upgrade Docker-GitLab: Uninstall 12.9.2-0055 successfully
2020/04/20 11:34:25 upgrade Docker-GitLab 12.9.2-0055 Begin preinst
2020/04/20 11:34:25 upgrade Docker-GitLab 12.9.2-0055 End preinst ret=[0]
2020/04/20 11:34:25 upgrade Docker-GitLab 12.9.2-0055 Begin /bin/mv -f /volume1/@tmp/pkginstall/package /volume1/@appstore/Docker-GitLab
2020/04/20 11:34:25 upgrade Docker-GitLab 12.9.2-0055 End /bin/mv -f /volume1/@tmp/pkginstall/package /volume1/@appstore/Docker-GitLab ret=[0]
2020/04/20 11:34:25 upgrade Docker-GitLab 12.9.2-0055 Begin /bin/mkdir -p /var/packages/Docker-GitLab
2020/04/20 11:34:25 upgrade Docker-GitLab 12.9.2-0055 End /bin/mkdir -p /var/packages/Docker-GitLab ret=[0]
2020/04/20 11:34:25 upgrade Docker-GitLab 12.9.2-0055 Begin /bin/mv -f /volume1/@tmp/pkginstall/INFO /var/packages/Docker-GitLab/INFO
2020/04/20 11:34:25 upgrade Docker-GitLab 12.9.2-0055 End /bin/mv -f /volume1/@tmp/pkginstall/INFO /var/packages/Docker-GitLab/INFO ret=[0]
2020/04/20 11:34:25 upgrade Docker-GitLab 12.9.2-0055 Begin /bin/rm -rf /var/packages/Docker-GitLab/scripts
2020/04/20 11:34:25 upgrade Docker-GitLab 12.9.2-0055 End /bin/rm -rf /var/packages/Docker-GitLab/scripts ret=[0]
2020/04/20 11:34:25 upgrade Docker-GitLab 12.9.2-0055 Begin /bin/mv -f /volume1/@tmp/pkginstall/scripts /var/packages/Docker-GitLab/scripts
2020/04/20 11:34:25 upgrade Docker-GitLab 12.9.2-0055 End /bin/mv -f /volume1/@tmp/pkginstall/scripts /var/packages/Docker-GitLab/scripts ret=[0]
2020/04/20 11:34:25 upgrade Docker-GitLab 12.9.2-0055 Begin /bin/rm -rf /var/packages/Docker-GitLab/WIZARD_UIFILES
2020/04/20 11:34:25 upgrade Docker-GitLab 12.9.2-0055 End /bin/rm -rf /var/packages/Docker-GitLab/WIZARD_UIFILES ret=[0]
2020/04/20 11:34:25 upgrade Docker-GitLab 12.9.2-0055 Begin /bin/mv -f /volume1/@tmp/pkginstall/WIZARD_UIFILES /var/packages/Docker-GitLab/WIZARD_UIFILES
2020/04/20 11:34:25 upgrade Docker-GitLab 12.9.2-0055 End /bin/mv -f /volume1/@tmp/pkginstall/WIZARD_UIFILES /var/packages/Docker-GitLab/WIZARD_UIFILES ret=[0]
2020/04/20 11:34:25 upgrade Docker-GitLab 12.9.2-0055 Begin /bin/rm -rf /var/packages/Docker-GitLab/conf
2020/04/20 11:34:25 upgrade Docker-GitLab 12.9.2-0055 End /bin/rm -rf /var/packages/Docker-GitLab/conf ret=[0]
2020/04/20 11:34:25 upgrade Docker-GitLab 12.9.2-0055 Begin /bin/mv -f /volume1/@tmp/pkginstall/conf /var/packages/Docker-GitLab/conf
2020/04/20 11:34:25 upgrade Docker-GitLab 12.9.2-0055 End /bin/mv -f /volume1/@tmp/pkginstall/conf /var/packages/Docker-GitLab/conf ret=[0]
2020/04/20 11:34:25 upgrade Docker-GitLab 12.9.2-0055 Begin postinst
2020/04/20 11:36:38 upgrade Docker-GitLab 12.9.2-0055 End postinst ret=[2]
2020/04/20 11:36:38 upgrade Docker-GitLab from 12.9.2-0055 to 12.9.2-0055 failed
2020/04/20 11:36:38 upgrade Docker-GitLab 12.9.2-0055 Begin /bin/rm -rf /volume1/@tmp/pkginstall
2020/04/20 11:36:38 upgrade Docker-GitLab 12.9.2-0055 End /bin/rm -rf /volume1/@tmp/pkginstall ret=[0]
Screenshot 2020-04-20 at 13 31 28
jboxberger commented 4 years ago

Ok we had an error on. 2020/04/20 10:53:18 upgrade Docker-GitLab 12.9.2-0055 End postinst ret=[2] 2020/04/20 10:53:18 upgrade Docker-GitLab from 12.7.5-0055 to 12.9.2-0055 failed

2020/04/20 11:34:25 upgrade Docker-GitLab 12.9.2-0055 Begin postuninst 2020/04/20 11:34:25 upgrade Docker-GitLab 12.9.2-0055 End postuninst ret=[2]

It looks like you had an issue during the installation. And your data is untouched. That's good. We can fix Git lab but we can not fix data easily.

I would reccomend to find the problem, to get the right solution. I have to do some work by now and can have a deeper look at you issue tonight.

Please provide the: /var/log/packages/Docker-GitLab.log

Do you have at least 12 GB free space on the volume where docker is installed?

You can also have a look for problems here: _/var/log/basherr.log /var/log/apparmor.log /var/log/messages

If it's urgent for you you can try this solutions, but i highly recommend to keep calm and find the problem first to get the right solution.

First Attempt: 1) After you backed up the data you uninstall the installed Gitlab-Docker package. IMPORTANT: When asked to keep the Data, answer YES! 2) After de-installation reinstall the 12.7.5 package. Package should detect previously installed package and ask you to use existing data. Reply with YES.

(When First Attempt failed) Second Attempt: 1) copy /volume1/docker/gitlab to /volume1/docker/gitlab.bak (do not use the backup here! make a new copy. do never touch the backed up files, they are our insurance, just copy them) 2) check permission /volume1/docker/gitlab.bak are the same as /volume1/docker/gitlab (important) 3) uninstall the installed Gitlab-Docker package. When asked to keep the Data, answer NO! 4) intstall the 12.7.5 Gitlab-Docker package with stock settings. Untick "start package after install" 5) delete /volume1/docker/gitlab (this is from the new just installed stock package) 6) move or copy /volume1/docker/gitlab.bak to /volume1/docker/gitlab 7) start the package from DSM

jirsbek commented 4 years ago

I believe /var/log/packages/Docker-GitLab.log revealed the issue:

/usr/syno/etc/packages/Docker-GitLab//config: line 15: unexpected EOF while looking for matching `"'
/usr/syno/etc/packages/Docker-GitLab//config: line 16: syntax error: unexpected end of file

One of the ENV parameters was missing a quote... 🤦‍♂️ Now update went well without any hassle.

Thank you again for your time with your package as well as with the support.

jboxberger commented 4 years ago

Great! I am very happy that you were able to solve the Problem.

Could you Please give me more informations about the exact cause, maybe config samples where the problem happens. I want to check how the missing quote could happen and maybe prevent this issue in the future.

Kind Regards

jirsbek commented 4 years ago

Of course. In the past (approx. 2 years ago) I believe I've edited ENV variables in /usr/syno/etc/packages/Docker-GitLab/config trying to set the default values.

I've probably missed the ending quote in one of the records that caused the problem so update to 12.9.2-0055 failed. It's interesting that prior updates went well.