jboxberger
commented
3 years ago Hi Helmut,
its because synology changed the SPK url. I've pushed a update a minute ago which should fix it. Just pull.
Closed helmut-steiner closed 3 years ago
jboxberger
commented
3 years ago Hi Helmut,
its because synology changed the SPK url. I've pushed a update a minute ago which should fix it. Just pull.
jboxberger
commented
3 years ago I am very happy that you trying it on your own and hope you will have success. But pelase be carefull, i have not published any release not because of time issues. I got stuck during the gitlab DB update. The Update breaks to a inconstant state and has to be fully rollback. Luckily i do my test on a VM and this do not affect my production.
Because of the upgrade fail i do not publish an "maybe working" release because i do not want the people to break their installation. I am working on a complete standalone package using official docker repos. But this will still take a while. I got the toolkit running and the signature is also working. Now i am building up the package and i hope i can come up with a stable package this year and a migration path from this package to the new one.
Kind Regards
helmut-steiner
commented
3 years ago Hey Juri, Thanks for the fast reply and fix. The build works again. I will try it on my test system. After having had the update issues I always try things first on a non-production unit. I will let you know if the DB update works. Good luck with the new package and as mentioned in issue #44 - let me know if you need help!
helmut-steiner
commented
3 years ago So the update from 13.0.3 to 13.3.4 fails due to insufficient privileges. There is a new extension needed and while starting up the container and performing the upgrade it tries to install the extension which fails:
PG::InsufficientPrivilege: ERROR: permission denied to create extension "btree_gist"
@jboxberger Do you know how to set the right permissions inside docker?
helmut-steiner
commented
3 years ago See this for a workaround: https://github.com/sameersbn/docker-gitlab/issues/2214 I think the script has to be adapted for the upgrade to work.
jboxberger
commented
3 years ago ok give me a sec
jboxberger
commented
3 years ago Ive added btree_gist to the synology_gitlab_postgresql, hopefully sameersbn/postgresql supports it. you can pull and give it a try.
helmut-steiner
commented
3 years ago Okay. Just give me a couple of minutes. I have to reinstall v13.0.3 and import the backup before trying the upgrade again.
helmut-steiner
commented
3 years ago Unfortunately I get following error on building:
parse error: Expected another key-value pair at line 1, column 235
parse error: Expected another key-value pair at line 1, column 235
parse error: Expected another key-value pair at line 1, column 235
sed: -e expression #1, char 0: no previous regular expressionahh.. fixed, was a typo
jboxberger
commented
3 years ago The extension seems to load properly now
jboxberger
commented
3 years ago We are one step further. BUT after a clean install the Login fails with
` Completed 500 Internal Server Error in 20ms (ActiveRecord: 4.9ms | Elasticsearch: 0.0ms | Allocations: 6446)
ActiveRecord::StatementInvalid (PG::UndefinedColumn: ERROR: column users.ghost does not exist
LINE 1: ...COUNT(*) FROM (SELECT 1 AS one FROM "users" WHERE "users"."g...
^
`
and there are also issues with
2020-09-30T12:28:41.899Z: Cached record for ApplicationSetting couldn't be loaded, falling back to uncached record: PG::UndefinedTable: ERROR: relation "application_settings" does not exist LINE 1: SELECT "application_settings".* FROM "application_settings" ... ^
i think this comes all from the gitlab image and thats why i want to use the original gitlab-ce image to minimize problems and have a bigger community to get workaround and fixes
helmut-steiner
commented
3 years ago I can confirm that building and upgrading to 13.3.4 works without issues now. I haven't tried a clean installation yet. I am closing this issue as #44 contains more information on the upgrading hassle.
helmut-steiner
commented
3 years ago Hey Juri, Just for you to know: I thought everything worked but on my production system I encountered weird login issues. Probably the issue you mentioned above. It didn't occur right after starting the container but a few minutes later. So the initial login worked... Quite weird. I reverted back to 13.0.3 on my production environment. :(
jboxberger
commented
3 years ago Merde... this comes from Error SELECT COUNT(*) FROM (SELECT 1 AS one FROM "users" WHERE "users"."ghost" IS NULL LIMIT $1) subquery_for_count ... i am currently investigating. the column is really missing. but i am still not sure if the DB is wrong or the code ...
I've made a clean install on PSQL 11 and PSQL 12 with still the same problem. :-(
jboxberger
commented
3 years ago jboxberger
commented
3 years ago Traced it down.
https://gitlab.com/gitlab-org/gitlab/-/blob/master/CHANGELOG.md The Column has been removed with GitLab 13.4.0
It looks like sameersbn image is useing the code from 13.3.4 on the 13.4.0 schema. BUT There is a chance that this will work once sameersbn update to 13.4.0
helmut-steiner
commented
3 years ago Great! I already suspected something like this. :-) Thanks Juri!
jboxberger
commented
3 years ago Looks like this is the issue, but unresolved now. https://gitlab.com/gitlab-org/omnibus-gitlab/-/issues/5627
jboxberger
commented
3 years ago The error comes with the Gitlab 13.2.1, the previous 13.0.6 so not have the issue with the "users"."ghost" issue
Hey Juri, I tried building a new version for myself with your build script but it fails. I got Kali installed on WSL2 and build there. Here is my console output: