search

jbr / follow-that-bird

An implementation for Tweak-the-Tweet style emergency-response twitter syntaxes
http://crisiscommons.org/Tweak-The-Tweet
12 stars 12 forks source link

Tweet.need_triage is gone, but TweetsController#collection still uses it #14

Closed jamesarosen closed 14 years ago

jamesarosen commented 14 years ago

I just pulled from jbr/master and got the following diff:

<<<<<<< HEAD:app/models/tweet.rb
  # This is the method that the core view will use to 
  # show tweets that still need triaging.
  #
  # We will need to tweak the variables here for best
  # user experience.
  def self.need_triage
    self.recent(24.hours.ago).
         upvoted_less_than(5).
         downvoted_less_than(5).
         random.
         limit(15)
=======
  has_many :taggings, :dependent => :destroy

  def to_s
    "#{from_user}: #{text}"
>>>>>>> 06dfbaabcbc4ab64d2407ddb1a515b98f2716d08:app/models/tweet.rb

If you're planning on using Taggings instead of the need_triage method to look up Tweets, you'll have to change TweetsController to compensate. I don't see how the current version could run.

jbr commented 14 years ago

I believe this has been fixed. Closing the ticket in an effort to keep the issues page tidy. Please reopen if this isn't resolved.