jbr / follow-that-bird

An implementation for Tweak-the-Tweet style emergency-response twitter syntaxes
http://crisiscommons.org/Tweak-The-Tweet
12 stars 12 forks source link

tweets.tweet_id should be either a string or a long int #18

Closed nbudin closed 14 years ago

nbudin commented 14 years ago

Commit d00ed069609d9145f2af794a498e6e1a67bef1b5 seems to have removed the migration that converted tweet_id to a string. Unfortunately, at least on MySQL, this results in all tweet_ids overflowing the field.

This makes it impossible to vote on tweets (for example), because all Tweet records end up with the same tweet_id and thus fail validation.

jbr commented 14 years ago

Yikes. I guess I've been merging a bit optimistically. Reverting; it definitely needs to be a string.

nbudin commented 14 years ago

There is some other stuff in that commit that looks useful, though - a geotag parser, apparently. I'm not sure whether or not it works. Sam can probably provide more information about it if he can be reached.

jbr commented 14 years ago

Re-added in a9d9305aeba1656a908fb1e6e54b00cc46682915

nbudin commented 14 years ago

Looks good, thanks!