search

jbramwell / VSTS-Tools

Various command-line utilities for interacting with Visual Studio Team Services (VSTS)
MIT License
11 stars 7 forks source link

Upgrade powershell execution handler #13

Closed Thilas closed 4 years ago

Thilas commented 4 years ago

This PR aims at using the PowerShell3 execution handler instead of the deprecated PowerShell one. This change requires to get arguments of the ps1 scripts differently (i.e. using $env:INPUT_XXX variables). I didn't identify anything else to patch given the tasks logic. See https://github.com/microsoft/azure-pipelines-task-lib/tree/master/powershell for more details.

A more robust way to go would be to directly rely on VstsTaskSdk module. But this would require either to commit and push this module for each task or to restore it on the fly when building the extension (both locally and in the CI).

NB: ps1 files were removed in a previous commit (mistake?). I reverted this in order to patch the scripts.

Fixes #12.

Thilas commented 4 years ago

I just splitted my initial commit in 2 to better understand the actual change I'm proposing here (i.e. the 2nd commit).

What about the tasks versioning? Do I need to bump the versions myself in each relevant json files or is it automatic?

Thilas commented 4 years ago

@jbramwell, any chance you could review this PR soon? Thank you.