search

jbranchaud / ocelot

Because you're awesome!
4 stars 1 forks source link

Notation for specific line numbers and line number ranges #2

Open jbranchaud opened 11 years ago

jbranchaud commented 11 years ago

In the event that we have two distinct changes within an individual file, we may want to use annotations that are more fine-grained than the file-level ones. Consider the following notation that allows for more specificity in the annotations:

[src/Shape.java@33-44]
some message
[src/Shape.java@55-58,62-64]
some message
[src/Shape.java@69-74|src/Square.java@22-45]
some message
jurgns commented 11 years ago

Very much in favor of this. We may need to be concerned with how the different annotations work in conjunction with a regex based approach to identifying files though. Thoughts?

jbranchaud commented 11 years ago

I am also a fan of this feature. I also had the same concern of the possible interference of the regex feature. I am not sure how we want to deal with it, but one possibility could be to signal that regex is happening with some notation (similar to how they do in python). I must admit though that as I write this, I don't like it. Seems a bit to clunky. Let me know if you can think of a lightweight way of making regex distinct.

jbranchaud commented 11 years ago

I have added a description of this feature in the experimental features section of the v0.1.4 specification.