search

jbrandwood / v810-gcc

Patches and build scripts to make a GCC4 toolchain for the NEC V810 cpu used in the NEC PC-FX and Nintendo VirtualBoy
15 stars 7 forks source link

Fix compiling issues on Linux. #3

Closed gameblabla closed 3 years ago

gameblabla commented 3 years ago

This should also still work on Windows. Werror prevents binutils from being compiled with GCC 9.3.

jbrandwood commented 3 years ago

Thank you for the report, I'll take a look at the errors reported by the latest GCC compiler.

I prefer to leave "-Werror" in place and just fix the problems in the source code, if possible.

Some of the previous warnings showed up important errors in the GCC source code that badly needed to be fixed ... while others were just coding-style issues that could be ignored by disabling the individual warning messages.

jbrandwood commented 3 years ago

Thank you so much for reporting this, and fix providing your work-around fix! :-)

I am not going to accept your pull-request, because I prefer to fix (where possible) the underlying problems that the new GCC warnings point out with the old source code.

I have just checked-in new patches which fix a couple of real problems with the old code that the newer GCC has pointed out, but also specifically removes some of the new warnings that aren't really problems with the old compiler.

Best wishes,

John