search

jbreams / gonepass

GTK+ 1Password reader
Other
130 stars 12 forks source link

Please add C++11 standard requirement #29

Open barracuda156 opened 1 year ago

barracuda156 commented 1 year ago

The build fails spectacularly with an older compiler which does not support C++11. CMake should require the standard.

jbreams commented 1 year ago

The C++ standard is set here https://github.com/jbreams/gonepass/blob/3da5cfa120b4e530092d9cda5634e72f22b048d8/CMakeLists.txt#L15, what else needs to be done here?

barracuda156 commented 1 year ago

@jbreams Thank you for responding!

I think it will be better to have it required: https://cmake.org/cmake/help/latest/prop_tgt/CXX_STANDARD_REQUIRED.html Otherwise somebody gets a failure and won’t immediately know why.

barracuda156 commented 1 year ago

@jbreams FYI, I have added it to Macports: https://ports.macports.org/port/gonepass/details