search

jbreams / gonepass

GTK+ 1Password reader
Other
130 stars 12 forks source link

Gonepass crashes when trying to view some passwords #6

Open jonnybarnes opened 8 years ago

jonnybarnes commented 8 years ago

As best I can tell its passwords which also have an associated “One-Time Password” which cause the crash.

jbreams commented 8 years ago

Do you have a stacktrace or a core dump or something I could look at? I just tried creating a test password item with a one-time password and it didn't crash for me.

jbreams commented 8 years ago

Well, the coredump wasn't usable because I don't have a copy of your binaries. Also, I realized coredumps are probably a bad idea here. I had a theory that maybe OTP fields have binary data that isn't null-terminated, but it looks like binary data gets base64 encoded, and the JSON library I'm using guarantees all strings will be null-terminated after version 2.6. Do you think you could construct a test keychain with fake passwords that causes the problem?

joaosoares commented 8 years ago

This problems happens because there's no error checking when unpacking the json string for a section without a title (like OTP sections). I have fixed it by checking the error code that json_unpack throws on the process_section function. I'm finishing including support for OTPs and then I'll most likely submit a pull request, if that's fine.

jbreams commented 8 years ago

Great thanks!