search

jbreckmckye / electron-auth0-login

Helper widget for Auth0 authentication in Electron desktop apps
MIT License
28 stars 19 forks source link

Feature Request: Config access to BrowserWindow object #11

Closed malammar closed 4 years ago

malammar commented 4 years ago

Our application has a certain style and UX standards that we need to follow. The login window that this package has a hard-coded configuration that doesn't allow us to hide the titlebar, chrome, or specify the size.

Ideally, we'd like access to a subset of the BrowserWindow parameters and have those passed down through the standard config object in a property called "browserWindowConfig".

jbreckmckye commented 4 years ago

That would definitely be possible. I could also expose the browserWindow itself?

I'm a bit busy today but might have time later in the week. Alternatively I'm happy to accept a PR? The class itself is fairly short.

jbreckmckye commented 4 years ago

@malammar Would this PR work for you? https://github.com/jbreckmckye/electron-auth0-login/pull/12

jbreckmckye commented 4 years ago

12 is merged now.