made isLoggedIn function asynchronous

jbreckmckye / electron-auth0-login

Helper widget for Auth0 authentication in Electron desktop apps

MIT License

27 stars 19 forks source link

Closed MLD5000 closed 3 years ago

MLD5000 commented 3 years ago

When checking for authentication, isLoggedIn always returns true due to the promise being returned in the ctx.tokens.get() call.

This was causing logic errors when checking for prior authentication in electron applications.

jbreckmckye commented 3 years ago

Oh, great spot. I should be able to cut a release of this over the weekend.

jbreckmckye commented 3 years ago

@MLD5000 Could you update the package.json version field to 2.0.2? That will be the version of the bugfix release.

MLD5000 commented 3 years ago

@jbreckmckye Updated version as requested.

jbreckmckye commented 3 years ago

Thanks for your PR, I've just merged this. I'll comment again once the new version is released.

MLD5000 commented 3 years ago

Awesome, thanks!

jbreckmckye commented 3 years ago