search

jbreckmckye / electron-auth0-login

Helper widget for Auth0 authentication in Electron desktop apps
MIT License
27 stars 19 forks source link

Issue when trying to install with npm #34

Closed chasebenedict1 closed 1 year ago

chasebenedict1 commented 2 years ago

I am getting a conflict when trying to install to my electron project using npm. Has anyone seen this issue before and is there a way to resolve it?

image

jbreckmckye commented 2 years ago

If I update the peerDependency range to >= 7 it should work fine. In the meanwhile just use --force.

chasebenedict1 commented 2 years ago

Thanks for the fast response. I will force it then, I just wanted to make sure that it wasn't going to be a security issue or something if I forced it.

thomasklein-toptal commented 1 year ago

Hi @jbreckmckye ! Thanks for the plugin first of all. Regarding the peerDependency update: When do you plan to do it? The current electron version is 20.

jbreckmckye commented 1 year ago

@thomasklein-toptal I forgot about this... should be able to look into it one night this week

EDIT: Probably later as I am currently without stable internet

roberttolton commented 1 year ago

Any update for this?

npm ERR! code ERESOLVE
npm ERR! ERESOLVE could not resolve
npm ERR! 
npm ERR! While resolving: electron-auth0-login@2.0.3
npm ERR! Found: electron@22.1.0
npm ERR! node_modules/electron
npm ERR!   electron@"*" from @types/electron@1.6.10
npm ERR!   node_modules/@types/electron
npm ERR!     dev @types/electron@"^1.6.10" from the root project
npm ERR!   dev electron@"^22.1.0" from the root project
npm ERR! 
npm ERR! Could not resolve dependency:
npm ERR! peer electron@"^7.1.9" from electron-auth0-login@2.0.3
npm ERR! node_modules/electron-auth0-login
npm ERR!   electron-auth0-login@"^2.0.3" from the root project
npm ERR! 
npm ERR! Conflicting peer dependency: electron@7.3.3
npm ERR! node_modules/electron
npm ERR!   peer electron@"^7.1.9" from electron-auth0-login@2.0.3
npm ERR!   node_modules/electron-auth0-login
npm ERR!     electron-auth0-login@"^2.0.3" from the root project
npm ERR! 
npm ERR! Fix the upstream dependency conflict, or retry
npm ERR! this command with --force, or --legacy-peer-deps
npm ERR! to accept an incorrect (and potentially broken) dependency resolution.
npm ERR! 
npm ERR! See /Users/runner/.npm/eresolve-report.txt for a full report.
jbreckmckye commented 1 year ago

@roberttolton Try version 2.0.4