search

jbreckmckye / electron-auth0-login

Helper widget for Auth0 authentication in Electron desktop apps
MIT License
28 stars 19 forks source link

Not working with keytar 5 #7

Closed malammar closed 4 years ago

malammar commented 4 years ago

The optionalPeerDependency defined in package.json:

  "optionalPeerDependencies": {
    "keytar": "4.3.0"
  }

results in this error when running yarn start with electron 7 and keytar 5 installed:

 App threw an error during load
Error: Version "5.0.0" of module "keytar" required by "electron-auth0-login" does not satisfy required range "4.3.0".
    at realRequire (c:\Users\Mustafa\dev\smart-margin-desktop\node_modules\codependency\index.js:184:9)
    at requirePeer (c:\Users\Mustafa\dev\smart-margin-desktop\node_modules\codependency\index.js:326:10)
    at Object.<anonymous> (c:\Users\Mustafa\dev\smart-margin-desktop\node_modules\electron-auth0-login\dist\index.js:20:16)
    at Module._compile (internal/modules/cjs/loader.js:880:30)
    at Object.Module._extensions..js (internal/modules/cjs/loader.js:892:10)
    at Module.load (internal/modules/cjs/loader.js:735:32)
    at Module._load (internal/modules/cjs/loader.js:648:12)
    at Module._load (electron/js2c/asar.js:717:26)
    at Function.Module._load (electron/js2c/asar.js:717:26)
    at Module.require (internal/modules/cjs/loader.js:775:19)
    at require (internal/modules/cjs/helpers.js:68:18)
    at Object.<anonymous> (c:\Users\Mustafa\dev\smart-margin-desktop\public\auth\auth.js:1:28)
    at Module._compile (internal/modules/cjs/loader.js:880:30)
    at Object.Module._extensions..js (internal/modules/cjs/loader.js:892:10)
    at Module.load (internal/modules/cjs/loader.js:735:32)
    at Module._load (internal/modules/cjs/loader.js:648:12)

I've tested electron-auth0-login with keytar 5/electron 7 and everything seems to work.

jbreckmckye commented 4 years ago

Okay, should be an easy upgrade. I'll do it tonight.

jbreckmckye commented 4 years ago

Released as 1.1.0 (https://www.npmjs.com/package/electron-auth0-login)

malammar commented 4 years ago

Works great. Thanks for the amazingly fast turnaround!