jbredwards / Nether-API

A Minecraft mod that serves as a library for anyone wanting to add nether biomes, also unifies other mods' nether biomes!
5 stars 0 forks source link

"Just Enough Dimensions" mod incompatibility #3

Open xkforce opened 6 months ago

xkforce commented 6 months ago

Whether the mod modifies the terrain or not, netherapi expects its worldproviders to be used in the nether and end. While troubleshooting a crash that occurred after two worlds are created without a restart of the game, I realized that justenoughdimensions and netherapi were conflicting with one another. Specifically the JED worldprovider needs to be used for the End because some JED functionality necessary for the pack to function properly in that dimension requires JED's provider. The nether worldprovider does not need to be JED's which is why only the end worldprovider was an issue in this particular case. Currently I do not have a workaround for this that would allow the functionality needed for the End to be compatible with netherapi.

jbredwards commented 6 months ago

I'm changing the title of this issue to "Just Enough Dimensions mod incompatibility" to reflect the actual problem, since it wouldn't be too hard to add compatibility in the future :)

The inability to toggle this mod's world providers is by design. They're what makes it possible to add custom biomes, structures, fog color, music, ambient effects (particles, sounds), and edit structures, which is all kinda the whole point of the mod :P

xkforce commented 6 months ago

JED requires that its worldprovider be used for a whole swath of its features to work in that dimension for the same reasons nether api does.

jbredwards commented 6 months ago

JED requires that its worldprovider be used

Not necessarily. All that compatibility requires is for the active world provider to call JED functions and use its settings while that mod is present. I'll add that functionality in the future (probably in the next update or so)

CalaMariGold commented 5 months ago

Possibly related crash that occurred during world creation: https://mclo.gs/BIBAPt3

jbredwards commented 5 months ago

Possibly related crash that occurred during world creation: https://mclo.gs/BIBAPt3

@CalaMariGold This looks like the result of removing the nether or end entirely (and thus isn't exclusively related to JED), so can you move this to a new issue?

CalaMariGold commented 5 months ago

I haven't removed either dimension 🤔

CalaMariGold commented 5 months ago

I do override it with JED tho

{
    "dimensions": [
        {
            "dim": -1,
            "override": true,
            "dimensiontype": {
                "id": -1,
                "name": "Nether (JED)",
                "suffix": "_dim-1",
                "keeploaded": false,
                "worldprovider": "WorldProviderHellJED",
                "worldinfo_onetime": {}
            },
            "jed": {
                "CanRespawnHere": true,
                "CanSleepHere": "deny"
            }
        }
    ]
}
jbredwards commented 5 months ago

@CalaMariGold Can you send the full log (not just the crash-log)?

CalaMariGold commented 5 months ago

https://mclo.gs/7CxfXh7

CalaMariGold commented 4 days ago

Hi hi, any updates to this issue?

jbredwards commented 3 days ago

Hi hi, any updates to this issue?

It's hard working on multiple mods while also being a full-time college student, so I'll add support during winter break :)

CalaMariGold commented 2 days ago

Absolutely no worries at all ❤️ Take your time!