search

jbredwards / Subaquatic

A Minecraft mod that adds tons of ocean related things to the game!
7 stars 4 forks source link

compatibility fix for underground biomes #48

Closed xemnes closed 1 year ago

xemnes commented 1 year ago

adding a plant type for kelp, seagrass and sea pickle allows them to be placed and grow on underground biomes variants of terrain blocks

jbredwards commented 1 year ago

thank you for the pr, however this issue was fixed here in v1.2.0

xemnes commented 1 year ago

yes, i saw this and messaged you on discord. i made this pr before you fixed it yourself haha. its not a problem though.

but i did wonder if my fix was a better approach to yours? unsure of the performance difference since it looks like you used asm to fix it whilst i just set a plant type for them which underground biomes accepts.