jbredwards / Subaquatic

A Minecraft mod that adds tons of ocean related things to the game!
7 stars 4 forks source link

Incompat with Cleanroom #72

Open kappa-maintainer opened 8 months ago

kappa-maintainer commented 8 months ago

First, this obfuscated check is not needed in Cleanroom, it should be 26 in both dev and prod Second, HashMap.computeIfAbsent() from here throws ConcurrentModificationException if called recursively in newer java, it should be changed to a manual null check I could patch all of them by Mixin or ASM, but it's a bad idea to patch mods that still maintaining