jbrischke / RatingsAnonymous

0 stars 0 forks source link

Checkpoint 2 Ready for Review #8

Open jbrischke opened 2 years ago

jbrischke commented 2 years ago

@pawaitemadisoncollege

I did what you said about the no ID change to the admin page, I am not 100% sure if I did it the best way though. I want to eventually hide all that input and only have images, those images can be something like a button that when clicked opens up the hidden information or maybe use the selectbyid function to get the data instead of all of it loading hmm.

pawaitemadisoncollege commented 2 years ago

I like that expand/collapse or hide/show idea @jbrischke. If performance is suffering due to a large amount of data, then yes, making another round trip to the server for info could work. I think it might be worth seeing how performance is and then making a decision.

I think that delete functionality seems better - nice for the user not to have to enter an id number. Looking forward to seeing the redesigned ui in action.

jbrischke commented 2 years ago

@pawaitemadisoncollege

I added some of the missing items including all pure useage of a genericdao instead of having 5 different daos reusing the same code. I also started to add unit tests, ill be adding alot more especially to test the relationships.

pawaitemadisoncollege commented 2 years ago

Good progress @jbrischke. Did the time log move? Looks like the link on the readme.md is broken?

jbrischke commented 2 years ago

@pawaitemadisoncollege

not sure why but my time log was missing, grabbed a previous copy from an earlier commit and added logs to it

pawaitemadisoncollege commented 2 years ago

Looks good now, @jbrischke, thanks!