search

jbroadway / elefant

Elefant, the refreshingly simple PHP CMS and web framework.
http://www.elefantcms.com
MIT License
209 stars 39 forks source link

Temp fix for Travis CI failing #263

Closed techanon closed 9 years ago

techanon commented 9 years ago

I saw this on the phpunit travis.yaml. Hoping this will suppress the fail warnings for travisCI until whatever is failing them gets fixed (or not).

jbroadway commented 9 years ago

No need, finally found a fix! :D

https://github.com/jbroadway/elefant/commit/e650854881c98d77916fa0b5336bc6dce3642488

The issue was Elefant's autoloader would only return false, passing it on to the next autoloader, if more than one autoload function had been registered. Otherwise, it throws a LogicException so we know the class wasn't found.

This works fine with most other autoloaders (including the PSR's) because they're actually registered. In the case of PHPUnit, its autoloader wasn't actually registered, so it would hit the exception and wouldn't know to pass it on gracefully.

All I had to do was throw an if (ELEFANT_ENV==='test') in there too and it works!

Thanks for the attempted workaround though :)

techanon commented 9 years ago

Does it still need the phpunit-story in the travis.yml?

jbroadway commented 9 years ago

I'm not sure, probably not actually.

It looks like it's actually not running the tests and dying partway through, so I've been looking into that. Says it passes though which is bizarre...