search

jbroadway / urlify

A fast PHP slug generator and transliteration library that converts non-ascii characters for use in URLs.
BSD 3-Clause "New" or "Revised" License
673 stars 79 forks source link

1.2.4 changed transliteration behaviour #72

Open tomjn opened 2 years ago

tomjn commented 2 years ago

Upgrading from 1.2.3 to 1.2.4 broke our test suite, in particular some characters are transliterated differently, breaking assertions and semver.

E.g. we test that това е текст на бълрагски за тест becomes tova-e-tekst-na-blragski-za-test which is true in 1.2.3 and false in 1.2.4.

In 1.2.4 it instead transliterates to tova-e-tekst-na-bielragski-za-test.

urlify version in out
1.2.3 бълрагски blragski
1.2.4 бълрагски bielragski

I'm sure the dependency has its reasons for doing this, but composer pulled in 1.2.4 automatically and broke out test suites, this should have been a 1.3.0 or a 2.0.0 release.

lux commented 2 years ago

That was my bad on not bumping the version with this update. Apologies for breaking your tests without proper warning!

tomjn commented 2 years ago

No worries, it was only 2 tests at the time, but it does mean we'll need to pin to 1.2.3 and do extra testing in case redirects cause issues