jbrooksuk / laravel-forge-action

Deploy your application to Laravel Forge with GitHub Actions.
https://james.brooks.page
MIT License
81 stars 5 forks source link

Remove unnecessary checkout, extract values to secrets #12

Closed gregkos closed 2 years ago

gregkos commented 2 years ago

Checking out the code is not necessary to trigger the deployment via URL, as the code is not used or transferred.

Not sure if the same applies to the API trigger, so I did not remove that, but I would assume it does.

Also extracted some values to GitHub secrets, to encourage best practices.

jbrooksuk commented 2 years ago

Thanks! You can remove the check out from both sections :)

gregkos commented 2 years ago

Thanks! You can remove the check out from both sections :)

Done!

jbrooksuk commented 2 years ago

Thanks!