jbruce12000 / kiln-controller

Turns a Raspberry Pi into an inexpensive, web-enabled kiln controller.
195 stars 109 forks source link

Auto tune issue #182

Closed MeltTechAu closed 3 weeks ago

MeltTechAu commented 1 month ago

When trying to autotune as per instructions it says can not import config adapt it copy examaple config but the kiln controller runs fine any thoughts jbruce im moving to the max 31856 and the new blinka software please help again thank you for your valued time cheers brett from melttech

och29 commented 1 month ago

I'm getting the same error. My process:

pi@kilnpi:~/kiln-controller $ systemctl stop kiln-controller ==== AUTHENTICATING FOR org.freedesktop.systemd1.manage-units ==== Authentication is required to stop 'kiln-controller.service'. Authenticating as: ,,, (pi) Password: ==== AUTHENTICATION COMPLETE ==== pi@kilnpi:~/kiln-controller $ python kiln-tuner.py recordprofile zn.csv Could not import config file. Copy config.py.EXAMPLE to config.py and adapt it for your setup. pi@kilnpi:~/kiln-controller $


config.py is present in the folder

pi@kilnpi:~/kiln-controller $ ls config.py kiln-tuner.py requirements.txt test-output.py docs lib start-on-boot test-thermocouple.py gpioreadall.py public state.json venv kiln-controller.py pycache storage watcher.py kiln-logger.py README.md Test ziplogs

jbruce12000 commented 1 month ago

can one of you comment out the try/except block near the top of kiln-tuner.py? post the error.

What I'll likely do is remove this try/except block so that folks can see what the real error is.

och29 commented 1 month ago

can one of you comment out the try/except block near the top of kiln-tuner.py? post the error.

What I'll likely do is remove this try/except block so that folks can see what the real error is.

pi@kilnpi:~/kiln-controller $ python kiln-tuner.py recordprofile zn.csv
usage: kiln-tuner.py [-h] [-c] [-t TARGET_TEMP] [-d TANGENT_DIVISOR] [-s]
kiln-tuner.py: error: unrecognized arguments: recordprofile zn.csv
MeltTechAu commented 1 month ago

Confirmed getting same error och29

jbruce12000 commented 1 month ago

This is an old branch and old version. you need to grab the latest code. I did a simulation on the head of the main branch and found a bug... then fixed it.

MeltTechAu commented 1 month ago

Getting same error with fresh dl today????

jbruce12000 commented 1 month ago

post the output of:

source venv/bin/activate
./kiln-tuner.py

The kiln-tuner parameter handling was changed last Dec and should no longer be called like this:

kiln-tuner.py recordprofile zn.csv

The default is now to save to tuning.csv. If there is existing documentation telling you to call it this way, lmk so I can fix it.

och29 commented 1 month ago

Thanks for the quick response, I suspect we're both using this documentation: https://github.com/jbruce12000/kiln-controller/blob/master/docs/ziegler_tuning.md#step-1-record-temperature-profie

To record the profile, run:

python kiln-tuner.py recordprofile zn.csv
jbruce12000 commented 1 month ago

The master branch is no longer supported. The main branch is now the active, supported branch. Switching branches may cause you some configuration or hardware re-work because it uses blinka instead of libraries I manage.

cd kiln-controller
git checkout main
git pull
och29 commented 1 month ago

Ah, then it's an issue with the link here then! https://github.com/jbruce12000/kiln-controller?tab=readme-ov-file#pid-tuning

jbruce12000 commented 1 month ago

fixed the README. All links that pointed to master or blinka now point to main.

good find. lemme know if tuning still does not work for you.

MeltTechAu commented 1 month ago

Legend jbruce thank you so much have a great day mate!

jbruce12000 commented 1 month ago

@MeltTechAu how did that tuning work out? any problems?

jbruce12000 commented 3 weeks ago

closing. create a new issue if you find a new problem with the code or docs.

och29 commented 2 weeks ago

I have tested this now, confirmed solved.