search

jbrukh / bayesian

Naive Bayesian Classification for Golang.
Other
805 stars 128 forks source link

Initial TD-IDF work #14

Closed rawoke083 closed 8 years ago

rawoke083 commented 8 years ago

Added in TD-IDF support to use instead of plain word counts ! Works very well ! Lots of extra accuracy. See updated README for usage.

rawoke083 commented 8 years ago

Bump ?

jbrukh commented 8 years ago

Thanks, will review in the next days. Please run gofmt on the source.

rawoke083 commented 8 years ago

Oh ofcourse ! Will run and update pull request !

On 20 Aug 2016 09:30, "Jake Brukhman" notifications@github.com wrote:

Thanks, will review in the next days. Please run gofmt on the source.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/jbrukh/bayesian/pull/14#issuecomment-241185012, or mute the thread https://github.com/notifications/unsubscribe-auth/AFRfpKDxlgm5jS47jyh9ChbZZdj9h7Eoks5qhq0VgaJpZM4JOnEo .

jbrukh commented 8 years ago

Thanks for your patch. Added some comments.

Please add some tests.

rawoke083 commented 8 years ago

@jbrukh No problem. Will add in the next few days !

jbrukh commented 8 years ago

Thanks for the work. Mostly looks good. Please resolve conflicts with master and we can almost merge. :)

Thank you!

rawoke083 commented 8 years ago

Cool did resolve some on local branch. Having some difficulties ! Going to cancel pull request and create new p.r (without conflicts)

On 24 Aug 2016 21:31, "Jake Brukhman" notifications@github.com wrote:

Thanks for the work. Mostly looks good. Please resolve conflicts with master and we can almost merge. :)

Thank you!

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/jbrukh/bayesian/pull/14#issuecomment-242181517, or mute the thread https://github.com/notifications/unsubscribe-auth/AFRfpMORetlsfv55COIni-NUFxvi9pS8ks5qjJv_gaJpZM4JOnEo .