Add support for Knex 0.95

jbrumwell / mock-knex

A mock knex adapter for simulating a database during testing

MIT License

240 stars 71 forks source link

Add support for Knex 0.95 #127

Closed mattleff closed 3 years ago

mattleff commented 3 years ago

Fixes #123.

jbrumwell commented 3 years ago

@mattleff Thank you for the PR :) I will make some time this weekend to review :)

KrzysztofWilczek commented 3 years ago

@jbrumwell any chance to get this Knex 0.95 support this week? Really looking forward to this Cheers! All the best to You!

tw0517tw commented 3 years ago

Hi @jbrumwell , would like to know will this be reviewed soon? I'm looking forward to this being merged and published.

🎉

jbrumwell commented 3 years ago

@mattleff @tw0517tw @KrzysztofWilczek Last weekend I pulled this down and the tests failed, this weekend I narrowed it down to why they are failing and created the follow issue in knex (https://github.com/knex/knex/issues/4453)

av131996 commented 3 years ago

Is it the version 0.4.9 of mock-knex compatible with version 0.95.4 of knex? What version of mock-knex si compatible with knex 0.95+ ?

mlarcher commented 3 years ago

with about 500 open issues, I'm not sure we can expect a quick resolution on the knex issue. In the meantime, would there be an acceptable workaround allowing us to begin using mock-knex with 0.95 asap ?

ash-vd commented 3 years ago

You could install this branch and use that for the time being.

felixmosh commented 3 years ago

You can use patch-package in order to patch your node_modules.

This is what I did :]

hanstf commented 3 years ago

when will this be merged ? really need this ASAP

jbrumwell commented 3 years ago

I will merge it this weekend with a warning that streaming is not working properly with a link to the issue

jbrumwell commented 3 years ago

@mattleff thank you :) I have merged your PR and published under 0.4.10. Please let me know if you have any issues :+1: